Panzer: fix clang warnings #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rppawlo
added
pkg: Panzer
AT: AUTOMERGE
bartlettroscoe
approved these changes
Dec 14, 2018
| @@ -46,7 +46,7 @@ | |||
| namespace panzer | |||
| { | |||
| template <typename LO, typename GO> | |||
| class LocalMeshInfo; | |||
| struct LocalMeshInfo; | |||
There was a problem hiding this comment.
Is the actually type a 'struct' and not a 'class'?
There was a problem hiding this comment.
yes - clang picked up on the fact that the object was a "struct" but some files had forward declarations using "class". I just cleaned up all the forward declares.
bathmatt
approved these changes
Dec 14, 2018
There was a problem hiding this comment.
cortado > grep warning out | sort | uniq
1 warning generated.
3 warnings generated.
../EMPIRE-PIC/src/StepperOpSpObserver.hpp:70:16: warning: 'empire::StepperOpSpObserver<double>::observeBeforeStepper' hides overloaded virtual function [-Woverloaded-virtual]
../EMPIRE-PIC/src/StepperOpSpObserver.hpp:75:16: warning: 'empire::StepperOpSpObserver<double>::observeAfterStepper' hides overloaded virtual function [-Woverloaded-virtual]
/projects/empire/install-for-panzer/CLANG-3.9.0-RELEASE-SERIAL-STATIC/include/stk_io/FieldAndName.hpp:119:18: warning: private field 'm_location' is not used [-Wunused-private-field]
../src/emStepperOpSpObserver.hpp:70:16: warning: 'empire::em::StepperOpSpObserver<double>::observeBeforeStepper' hides overloaded virtual function [-Woverloaded-virtual]
../src/emStepperOpSpObserver.hpp:75:16: warning: 'empire::em::StepperOpSpObserver<double>::observeAfterStepper' hides overloaded virtual function [-Woverloaded-virtual]
cortado >
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Using Repos:
Pull Request Author: rppawlo |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe bathmatt ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 4058: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing clang warnings requested by empire